Skip to content

Conversation

@didiViking
Copy link
Contributor

Related to #7516

@didiViking didiViking requested a review from a team as a code owner December 2, 2025 14:42
@otelbot-docs otelbot-docs bot requested a review from a team December 2, 2025 14:42
@otelbot-docs otelbot-docs bot requested review from a team and theletterf and removed request for a team December 2, 2025 14:42
@otelbot-docs otelbot-docs bot requested a review from a team December 2, 2025 14:46
@didiViking
Copy link
Contributor Author

/fix:dict

@didiViking didiViking self-assigned this Dec 2, 2025
@otelbot-docs
Copy link
Contributor

otelbot-docs bot commented Dec 2, 2025

fix:dict applied successfully in run 19862666893.

@didiViking
Copy link
Contributor Author

@theletterf Hi, could we check a bit here this last error, it seems to point to a bug? Thank you.

@immavalls
Copy link
Contributor

@theletterf Hi, could we check a bit here this last error, it seems to point to a bug? Thank you.

I'll have a look

Copy link
Member

@vitorvasc vitorvasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error in the last workflow run is due to missing heading IDs when compared to the English version:

es/community/marketing-guidelines/index.html
  hash does not exist --- es/community/marketing-guidelines/index.html --> #goals-and-guidelines

Here's an example of how it looks in the Portuguese version: content/pt/community/marketing-guidelines.md. I've also left a few inline suggestions adding them.

@otelbot-docs otelbot-docs bot requested a review from a team December 3, 2025 13:49
@didiViking
Copy link
Contributor Author

@vitorvasc Thanks for the feedback, all applied. @krol3 @immavalls Can we have some feedback on the Spanish translation?

@didiViking didiViking requested a review from vitorvasc December 3, 2025 13:55
Copy link
Contributor

@immavalls immavalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mostly suggestions, it's my first review, so probably good if @krol3 can also have a look!

@didiViking didiViking requested a review from immavalls December 4, 2025 10:12
@didiViking
Copy link
Contributor Author

@immavalls Thank you for the excellent reviews, all applied. @krol3 @theletterf Please confirm if you have further Spanish edits, so we can move to approved/merged. Thank you!

Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ¡Gracias!

@theletterf theletterf enabled auto-merge December 4, 2025 10:19
@otelbot-docs otelbot-docs bot requested review from a team and krol3 and removed request for a team and immavalls December 4, 2025 10:19
@theletterf theletterf added this pull request to the merge queue Dec 4, 2025
Merged via the queue into open-telemetry:main with commit 4d9884a Dec 4, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from Opened to Done in SIG Comms: Docs Translation Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants