-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat [es] Create community/marketing-guidelines.md #8562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/fix:dict |
|
✅ |
|
@theletterf Hi, could we check a bit here this last error, it seems to point to a bug? Thank you. |
I'll have a look |
vitorvasc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error in the last workflow run is due to missing heading IDs when compared to the English version:
es/community/marketing-guidelines/index.html
hash does not exist --- es/community/marketing-guidelines/index.html --> #goals-and-guidelines
Here's an example of how it looks in the Portuguese version: content/pt/community/marketing-guidelines.md. I've also left a few inline suggestions adding them.
|
@vitorvasc Thanks for the feedback, all applied. @krol3 @immavalls Can we have some feedback on the Spanish translation? |
immavalls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, mostly suggestions, it's my first review, so probably good if @krol3 can also have a look!
|
@immavalls Thank you for the excellent reviews, all applied. @krol3 @theletterf Please confirm if you have further Spanish edits, so we can move to approved/merged. Thank you! |
theletterf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ¡Gracias!
Related to #7516